Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Add README.md & CHANGELOG.md size check for publishable tests #1977

Merged
merged 4 commits into from
Sep 22, 2023
Merged

👷 Add README.md & CHANGELOG.md size check for publishable tests #1977

merged 4 commits into from
Sep 22, 2023

Conversation

AlexV525
Copy link
Member

Inspired by dart-lang/pub-dev#6012.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 added the infra label Sep 22, 2023
@AlexV525
Copy link
Member Author

Yeah, a working example is here: https://github.com/cfug/dio/actions/runs/6269325403/job/17025585341?pr=1977

@AlexV525 AlexV525 mentioned this pull request Sep 22, 2023
Closed
@AlexV525 AlexV525 changed the title 👷 Add CHANGELOG.md size check for publishable tests 👷 Add README.md & CHANGELOG.md size check for publishable tests Sep 22, 2023
@AlexV525 AlexV525 marked this pull request as ready for review September 22, 2023 05:29
@AlexV525 AlexV525 requested a review from a team as a code owner September 22, 2023 05:29
@ueman
Copy link
Contributor

ueman commented Sep 22, 2023

How big are our changelog and readme files right now?

@AlexV525
Copy link
Member Author

How big are our changelog and readme files right now?

Quite far from the limit. And now we have separated docs, which decreases the risk of reaching the limit.
image

@AlexV525
Copy link
Member Author

How big are our changelog and readme files right now?

Now they are displayed in each run. https://github.com/cfug/dio/actions/runs/6270605319/job/17028785303?pr=1977

@AlexV525 AlexV525 added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit 4493f1e Sep 22, 2023
34 checks passed
@AlexV525 AlexV525 deleted the feat/check-changelog-size branch September 22, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @ueman